Fixed an issue when the collaboration service registers apps also for… #10107
Conversation
|
Code looks fine, although I'm not sure why CI is failing. |
2403905
force-pushed
the
issue-10087
branch
2 times, most recently
from
f0eaf82
to
e503839
Compare
2403905
requested review from
wkloucek,
micbar,
phil-davis and
individual-it
as code owners
.drone.star
Outdated
| @@ -1079,7 +1079,7 @@ def wopiValidatorTests(ctx, storage, wopiServerType, accounts_hash_difficulty = | |||
| "image": OC_CI_ALPINE, | |||
| "environment": {}, | |||
| "commands": [ | |||
| "curl -v -X PUT 'https://ocis-server:9200/remote.php/webdav/test.wopitest' -k --fail --retry-connrefused --retry 7 --retry-all-errors -u admin:admin -D headers.txt", | |||
There was a problem hiding this comment.
@individual-it @SagarGi Is test.wopitest name can be changed across all tests or this is a predefined file name for the wopi API validator?
There was a problem hiding this comment.
I think it's only used here, so your change should everything that needs to be changed
There was a problem hiding this comment.
The .wopitest is an extension for the validator, specially on ms 365
|
Ci failure is unrelated and under investigation, see #10127 |
|
I've added a |
2403905
force-pushed
the
issue-10087
branch
3 times, most recently
from
d159e40
to
c077249
Compare
|
I fixed some return codes on the app/open endpoint. We need to adapt the test expectations. @ScharfViktor FYI |
some tests return dowble response error: @2403905 will make fix it in reva |
|
@2403905 Sorry, i missed a return 🙈 |
2403905
force-pushed
the
issue-10087
branch
2 times, most recently
from
01f3855
to
2dd79a4
Compare
|
Please rebase |
… binary and unknown mime types.
2403905
force-pushed
the
issue-10087
branch
from
402ffa2
to
41124c6
Compare
|
Activity tests were failing because, there're full name in displayName for some activities but not for some. Examples: {
"value": [
{
"template": {
"message": "{user} added {resource} to {folder}",
"variables": {
"folder": {
"name": "Alice Hansen"
},
"resource": {
"name": "FOLDER"
},
"space": {
"name": "Alice Hansen"
},
"user": {
"displayName": "Alice"
}
}
}
},
{
"template": {
"message": "{user} shared {resource} with {sharee}",
"variables": {
"folder": {
"name": "Alice Hansen"
},
"resource": {
"name": "FOLDER"
},
"sharee": {
"displayName": "Brian"
},
"user": {
"displayName": "Alice"
}
}
}
},
{
"template": {
"message": "{user} added {resource} to {folder}",
"variables": {
"resource": {
"name": "newfile.txt"
},
"space": {
"name": "Alice Hansen"
},
"user": {
"displayName": "Brian Murphy"
}
}
}
},
{
"template": {
"message": "{user} updated {resource} in {folder}",
"variables": {
"resource": {
"name": "newfile.txt"
},
"space": {
"name": "Alice Hansen"
},
"user": {
"displayName": "Brian Murphy"
}
}
}
},
{
"template": {
"message": "{user} deleted {resource} from {folder}",
"variables": {
"resource": {
"name": "newfile.txt"
},
"space": {
"name": "Alice Hansen"
},
"user": {
"displayName": "Brian"
}
}
}
}
]
}{
"template": {
"message": "{user} added {resource} to {folder}",
"variables": {
"folder": {
"name": "Alice Hansen"
},
"resource": {
"name": "textfile.txt"
},
"space": {
"name": "Alice Hansen"
},
"user": {
"displayName": "Alice Hansen"
}
}
}
} |
|
Fixed an issue when the collaboration service registers apps also for…
… binary and unknown mime types.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: